First Last Prev Next    No search results available
Details
: [loopsimplify] Many pointless phi nodes are created
Bug#: 187
: libraries
: Scalar Optimizations
Status: RESOLVED
Resolution: FIXED
: All
: All
: 1.0
: P2
: minor
: 1.2

:
: code-quality
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Chris Lattner <sabre@nondot.org>
Assigned To: Chris Lattner <sabre@nondot.org>

Attachments


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2003-12-16 15:57
In .general_ci_points_4 function of 177.mesa, for example, the following
preheader block is created by the loop simplify pass:

no_exit.0.preheader:
%iy.2.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%ix.4.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%y1.1.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%y0.1.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%x1.1.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%x0.1.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1
]             
%z.0.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1 ]
             
%y.0.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1 ]
             
%x.0.ph = phi int [ 0, %cond_true.0 ], [ 0, %cond_true.1 ], [ 0, %cond_false.1 ]
             

This is a common occurance, so the loop simplify pass should try a bit harder to
clean things up for subsequent loop optimization passes.

-Chris
------- Comment #1 From Chris Lattner 2003-12-16 15:59:04 -------
This should be easy to fix, I just didn't want to forget about it.

-Chris
------- Comment #2 From Chris Lattner 2003-12-19 00:29:16 -------
This problem is fixed like so:
http://mail.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20031215/010354.html

Many fewer PHI nodes are created and inserted.  I feel much better now.  :)

-Chris

First Last Prev Next    No search results available